-
-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dear ImGui to 1.85 #530
Conversation
This is wrong, why would you remove the glewInit() call?! This will 100% break on a bunch, if not all platforms. |
Because in ImGui 1.85 OpenGL is initialized by the embedded loader:
ocornut/imgui#4445
If you review the demos you'll see it's now the standard way.
|
Has this been properly tested yet? |
Nope, only in a couple of Linux/amd64.
Unfortunately I don't have access to other architectures.
…On Wed, Dec 1, 2021 at 7:17 PM AlexandreRouma ***@***.***> wrote:
Has this been properly tested yet?
I afraid of switching to this embedded loader without being sure it still
handles OpenGL 2.0 (ES) properly on raspberry pi boards
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#530 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOVYFHY2FFAPT3SS3ZTBQLUOZRE7ANCNFSM5JE6IWIQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Alright, I'm gonna wait for this branch to be tested on other platforms before merging.
|
OpenGL is now initialized by ImGui embedded loader
Code updated as follows:
Tested on Linux/amd64 & Windows/x64. |
Alright, i'll check that the ImGui update was done correctly, some settings had to be changed in imconfig for the last version |
Looks like trying to get GL from pkg-config fails on MacOS, not really sure what the cleanest way to go about it is at this point. |
Alright, I've done this along with other changes in the pull request I just merge. |
Update ImGui to 1.85, solves ticket #529