Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dear ImGui to 1.85 #530

Closed
wants to merge 4 commits into from
Closed

Conversation

aeburriel
Copy link

Update ImGui to 1.85, solves ticket #529

@AlexandreRouma
Copy link
Owner

This is wrong, why would you remove the glewInit() call?! This will 100% break on a bunch, if not all platforms.

@aeburriel
Copy link
Author

aeburriel commented Dec 1, 2021 via email

@AlexandreRouma
Copy link
Owner

AlexandreRouma commented Dec 1, 2021

Has this been properly tested yet?
I'm afraid of switching to this embedded loader without being sure it still handles OpenGL 2.0 (ES) properly on raspberry pi boards

@aeburriel
Copy link
Author

aeburriel commented Dec 1, 2021 via email

@AlexandreRouma
Copy link
Owner

Alright, I'm gonna wait for this branch to be tested on other platforms before merging.
But before, a few things:

  1. If glew is not longer needed, it should be removed from the core CMakeLists.txt
  2. It's important to check if this change has any performance impact.

OpenGL is now initialized by ImGui embedded loader
@aeburriel
Copy link
Author

Code updated as follows:

  1. Re-added an include required for linking properly in Windows which I removed by accident.
  2. Removed all GLEW dependencies and updated readme.

Tested on Linux/amd64 & Windows/x64.
About the performance, I agree it should be tested in low-end devices. Dear ImGui update is mostly bugfixes, according to its changelog. Graphics access remains the same, the only difference is the way OpenGL is initialized.

@AlexandreRouma
Copy link
Owner

Alright, i'll check that the ImGui update was done correctly, some settings had to be changed in imconfig for the last version

@aeburriel aeburriel deleted the branch AlexandreRouma:master December 8, 2021 16:38
@aeburriel aeburriel closed this Dec 8, 2021
@aeburriel aeburriel deleted the master branch December 8, 2021 16:38
@aeburriel aeburriel restored the master branch December 8, 2021 16:39
@aeburriel aeburriel reopened this Dec 8, 2021
@AlexandreRouma
Copy link
Owner

AlexandreRouma commented Dec 10, 2021

Looks like trying to get GL from pkg-config fails on MacOS, not really sure what the cleanest way to go about it is at this point.

@AlexandreRouma
Copy link
Owner

Alright, I've done this along with other changes in the pull request I just merge.
Please confirm that the latest commit fixes the issues you were having and re-open if it doesn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants